Skip to content

fix: reconcile label lines during label updates - #2161

Open
xile611 wants to merge 1 commit into
developfrom
codex/fix-label-line-update
Open

xile611 wants to merge 1 commit into
developfrom
codex/fix-label-line-update

Conversation

@xile611

@xile611 xile611 commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Release
  • Other (about what?)

🔗 Related issue link

VisActor/VChart#4622

🐞 Bugserver case id

Only provide confirmed, public-safe case IDs. If unavailable, state that a product administrator must supply them. Only that product’s administrators may create cases; never use empty, placeholder or invented IDs. Collaboration guide (Chinese).

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

Read PR checks and merge process. Target develop; the advisory workflow accepts eligible same-repository, non-draft PRs created after 2026-11-06 17:05 Asia/Shanghai.

  • Reported actual commands, outcomes, report scope and skipped checks/reasons.
  • Ran relevant unit tests and full official-baseline comparison for product/dependency/case changes, or explained documentation-only applicability. Self-comparison is not a two-sided pass.
  • Described expected visual changes and regression coverage; retained execution errors and blockers.

Photo needs maintainer review; report-only/completed is not an all-Photo pass. Approve is an audit record and the Bot never merges. When Photo selection is explicitly enabled, only the saved pre-merge selection can update baselines after manual merge; other PRs retain their existing mode.

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

VisActor 工作流(CN):needs_changes

当前提交:9b88509e386bd598e06c3395e95a106fdc26435f

三项检查建议与 BugServer 人工确认

@visactor-review-bot visactor-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 1 issue that needs fixing; see the inline comment.

this.removeChild(prevLabelLine);
prevLabel.labelLine = undefined;
} else if (!prevLabelLine && curLabelLine) {
this.add(curLabelLine);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep a restored label line aligned with the animated text

When a label moves from inside-middle back to right with animationUpdate enabled (the new visual case does exactly this), _createLabelLine builds curLabelLine from the destination text bounds. _runUpdateAnimation animates the existing text, but LabelUpdate.onBind only animates a line when both prevLabelLine and curLabelLine exist. This branch therefore adds the new line immediately at its final points while the displayed text is still moving from inside the bar. The connector is visibly detached for the animation duration. Start or update the restored line in sync with the text, and assert an intermediate animation frame in the visual case.

@visactor-review-bot

Copy link
Copy Markdown

VisActor 工作流

结论:存在待修复或待调查项。
当前提交:9b88509;比较基线:675878d。
环境:CN;更新时间:2026-11-20T03:54:49.168Z。

检查项 状态 关键结果
CR ⚠️ failed 待处理 1;接受风险 0 查看结果
单测 ⚠️ failed 必要测试步骤未执行成功或被异常跳过 查看结果
Playwright ⏳ pending 尚未执行;等待 CR 完整结束并清零后构建与执行
Photo(原 BugServer / UNIC) ⏳ pending —

Photo 独立报告:流程完成不代表 Photo 通过。 差异解释不决定接受;合入前保存的选择可在人工 Merge 后更新基准,Photo 不阻断合入。

请核对 BugServer 默认全选清单,改选后保存,再手动 Merge;Approve 可选,仅记录操作。
Bot 仅提供 CR、单测、Playwright 三项检查建议,不强制阻止合入。
未 Approve,可直接 Merge。

Photo 基准选择尚未保存;不影响三项检查建议或人工合入。
等待完整报告及逐项解释;没有有效授权时不更新基准。

图片差异解释(0 项)

暂无已解释差异。

合入后 Photo 基准更新清单

没有已授权的基准更新。

版本与合入后状态

当前提交:9b88509e386bd598e06c3395e95a106fdc26435f;比较基线:675878dd5bc3aba15f1121998661d55a600994fd。

CN 结果仅证明上述实际范围;完整报告和原始差异继续保留。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant